Add Support for Downloading Package Using Commit Hash as the Reference #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and branch Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
threeal
force-pushed
the
download-pkg-support-commit-hash
branch
from
21e15a5
to
8595d5e
Compare
…it hash Signed-off-by: Alfi Maulana <alfi.maulana.f@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #169 by modifying the commands executed in the
cdeps_download_packagefunction to allow external packages to be downloaded using a commit hash as the reference. It also updates the tests in thetest_download_version.cmakefile to ensure the function can download packages using a branch name, tag name, or commit hash as the reference.