Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/gotestsum false positive #38

Merged
merged 3 commits into from
Jan 31, 2023
Merged

Fix/gotestsum false positive #38

merged 3 commits into from
Jan 31, 2023

Conversation

LordRonz
Copy link
Collaborator

@LordRonz LordRonz commented Jan 30, 2023 •
edited
Loading

Closes #37
See gotestyourself/gotestsum#141 for reference

@LordRonz LordRonz requested a review from threeal January 30, 2023 14:37
@LordRonz LordRonz self-assigned this Jan 30, 2023
@LordRonz LordRonz requested a review from threeal January 30, 2023 15:00
threeal
threeal approved these changes Jan 31, 2023
View reviewed changes
Copy link
Owner

@threeal threeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@threeal threeal merged commit bd41bd4 into main Jan 31, 2023
@threeal threeal deleted the fix/gotestsum-false-positive branch January 31, 2023 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@threeal threeal threeal approved these changes

Assignees

@LordRonz LordRonz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test Failed Using gotestsum
2 participants
@LordRonz @threeal