Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding static website docs #463

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Adding static website docs #463

merged 2 commits into from
Apr 14, 2024

Conversation

maayarosama
Copy link
Contributor

No description provided.

@maayarosama maayarosama mentioned this pull request Mar 24, 2024
Merged
5 tasks
Mik-TF
Mik-TF approved these changes Mar 24, 2024
View reviewed changes
Copy link
Contributor

@Mik-TF Mik-TF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did some small adjustments and made sure the solution is available on the rendered mdbook (added in summary and also in solutions' TOC). Hope it's fine with you.

I guess we can merge when it's at least on devnet.

@ramezsaeed ramezsaeed merged commit 56202dc into development Apr 14, 2024
@Mik-TF Mik-TF deleted the development_static_website branch April 18, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mik-TF Mik-TF Mik-TF approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@scottyeager scottyeager Awaiting requested review from scottyeager scottyeager is a code owner

@xmonader xmonader Awaiting requested review from xmonader xmonader is a code owner

@ramezsaeed ramezsaeed Awaiting requested review from ramezsaeed ramezsaeed is a code owner

@A-Harby A-Harby Awaiting requested review from A-Harby A-Harby is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maayarosama @Mik-TF @ramezsaeed