update domains and add domain page with new UI #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mik-tf
requested review from
AhmedHanafy725,
scottyeager,
xmonader,
ramezsaeed and
A-Harby
as code owners
ramezsaeed
reviewed
Dec 11, 2024
| - You can select the network interface | ||
| - `WireGuard` | ||
| - `Planetary` | ||
| - `Mycelium` | ||
|
|
There was a problem hiding this comment.
It will support all the network interfaces provided.
which mean it will depend on your choice when you created the VM, if you choose only mycelium so only mycelium will be there in the drop down menu.
if you choose all network when deployed a VM you can see all the network in the drop down menu.
Ex. for all network selected:
There was a problem hiding this comment.
OK thanks for the clarification. LMK if what I just committed works now.
ramezsaeed
approved these changes
Dec 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Work Done
Notes
Closes #706