Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support configuring default logger #589

Merged
merged 1 commit into from
May 9, 2021

Conversation

abom
Copy link
Contributor

@abom abom commented Apr 29, 2021

Description

Allow enabling/disabling default loguru stderr handler and setting its level.

Changes

  • Add default config for default logger
  • Re-add default handler with the new level

Related Issues

None

Checklist

  • Pre-commit hook is installed to do formatting checks before committing code...etc
  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2021

Codecov Report

Merging #589 (b1b514e) into development (ab86c5a) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #589      +/-   ##
===============================================
- Coverage        70.76%   69.64%   -1.12%     
===============================================
  Files               91       84       -7     
  Lines             4693     4283     -410     
===============================================
- Hits              3321     2983     -338     
+ Misses            1372     1300      -72     
Impacted Files Coverage Δ
jumpscale/core/config/config.py 93.33% <ø> (ø)
jumpscale/core/logging/__init__.py 100.00% <100.00%> (ø)
jumpscale/core/logging/logging.py 93.29% <100.00%> (-1.06%) ⬇️
jumpscale/clients/redis/redis.py 85.71% <0.00%> (-2.86%) ⬇️
jumpscale/core/base/meta.py 92.18% <0.00%> (-0.79%) ⬇️
jumpscale/core/base/factory.py 92.14% <0.00%> (-0.53%) ⬇️
jumpscale/sals/fs/__init__.py 62.39% <0.00%> (-0.42%) ⬇️
jumpscale/tools/codeloader/__init__.py
jumpscale/servers/gedis/server.py
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab86c5a...b1b514e. Read the comment docs.

@xmonader xmonader merged commit e96b1b5 into development May 9, 2021
@xmonader xmonader deleted the development_default_logger branch May 9, 2021 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants