support machine and network light deployments #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provider/network_parser.go
Outdated
Comment on lines
218
to
226
| nodesLight = append(nodesLight, isLight) | ||
| } | ||
|
|
||
| // if no nodes requires to use network version 4 then it is a light network | ||
| if !slices.Contains(nodesLight, false) { | ||
| light = true | ||
| } | ||
|
|
||
| return light, nil |
There was a problem hiding this comment.
Suggested change
| nodesLight = append(nodesLight, isLight) | |
| } | |
| // if no nodes requires to use network version 4 then it is a light network | |
| if !slices.Contains(nodesLight, false) { | |
| light = true | |
| } | |
| return light, nil | |
| if !isLight { | |
| return false, nil | |
| } | |
| } | |
| return true, nil |
rawdaGastan
force-pushed
the
development_support_version4
branch
from
886766b to
ef0d929
Compare
Eslam-Nawara
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues