Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard Suite Flist (Grid Stack Suite Part 1 of 3) #277

Closed
wants to merge 12 commits into from
Closed

Dashboard Suite Flist (Grid Stack Suite Part 1 of 3) #277

wants to merge 12 commits into from

Conversation

mik-tf
Copy link
Contributor

@mik-tf mik-tf commented Jul 24, 2024 •
edited
Loading

Work Done

  • Flist to deploy the Dashboard Suite (grid stack) on a micro VM on the TFGrid

Status

  • Ready for review
  • This is the first version

Project

Screenshot

  • While the deployment is being done, we set a basic HTML webpage giving the status of the grid stack deployment:
    image
    image
    image
    image

References

Future Work

  • We can easily improve on aspects such as the webpage during deployment
  • We can turn this flist into a dashboard app

github-advanced-security[bot]
github-advanced-security bot found potential problems Jul 24, 2024
View reviewed changes
tfgrid3/dashboard_suite/Dockerfile Fixed Show fixed Hide fixed
tfgrid3/dashboard_suite/Dockerfile Fixed Show fixed Hide fixed
tfgrid3/dashboard_suite/Dockerfile Fixed Show fixed Hide fixed
@mik-tf mik-tf marked this pull request as ready for review July 24, 2024 06:22
@mik-tf mik-tf changed the title Development dashboard suite v2 Dashboard Suite Flist (Basic Grid Stack) Jul 24, 2024
@mik-tf mik-tf changed the title Dashboard Suite Flist (Basic Grid Stack) Dashboard Suite Flist (Grid Stack Suite Part 1 of 3) Jul 24, 2024
@mik-tf mik-tf mentioned this pull request Jul 24, 2024
Closed
@mik-tf mik-tf mentioned this pull request Jul 24, 2024
Closed
@xmonader
Copy link
Collaborator

xmonader commented Aug 5, 2024

There're some alerts need fixing. the screenshots showing threefold.store and threefold.pro? are they the same instance pointed to with multiple records?

@mik-tf
Copy link
Contributor Author

mik-tf commented Aug 5, 2024 •
edited
Loading

I just tested on two domains at different moments in time. The deployment is done on the same URL.

I will check for the alerts. But the root alert was also here: #267, and it got approved so I wonder if this one is OK to leave?

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 5, 2024
View reviewed changes
tfgrid3/dashboard_suite/Dockerfile
@@ -0,0 +1,22 @@
FROM ubuntu:22.04

Check failure

Code scanning / Trivy

Image user should not be 'root' High

Artifact: tfgrid3/dashboard_suite/Dockerfile
Type: dockerfile
Vulnerability DS002
Severity: HIGH
Message: Specify at least 1 USER command in Dockerfile with non-root user as argument
Link: DS002
tfgrid3/dashboard_suite/Dockerfile
Comment on lines +3 to +4
RUN apt-get update && \
apt-get install -y git ufw openssh-server pv curl

Check failure

Code scanning / Trivy

'apt-get' missing '--no-install-recommends' High

Artifact: tfgrid3/dashboard_suite/Dockerfile
Type: dockerfile
Vulnerability DS029
Severity: HIGH
Message: '--no-install-recommends' flag is missed: 'apt-get update && apt-get install -y git ufw openssh-server pv curl'
Link: DS029
@mik-tf
Copy link
Contributor Author

mik-tf commented Aug 5, 2024

We won't use flist and dashboard apps for the grid stack.

@mik-tf mik-tf closed this Aug 5, 2024
@mik-tf mik-tf deleted the development_dashboard_suite_v2 branch August 5, 2024 16:23
@xmonader xmonader added this to the 3.15.x milestone Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hossnys hossnys Awaiting requested review from hossnys hossnys is a code owner

@coesensbert coesensbert Awaiting requested review from coesensbert coesensbert is a code owner

@PeterNashaat PeterNashaat Awaiting requested review from PeterNashaat PeterNashaat is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.15.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mik-tf @xmonader