Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations for included, excluded and priority nodes #1017

Closed
rawdaGastan opened this issue May 19, 2024 · 4 comments
Closed

Add validations for included, excluded and priority nodes #1017

rawdaGastan opened this issue May 19, 2024 · 4 comments
Assignees
Labels
farmerbot type_feature New feature or request
Milestone

Comments

@rawdaGastan
Copy link
Collaborator

Is your feature request related to a problem? Please describe

To make sure config file is valid, so farmer could notice if the date is wrong or messy

Describe the solution you'd like

Add validations for included, excluded and priority nodes

@rawdaGastan rawdaGastan added type_feature New feature or request farmerbot labels May 19, 2024
@Eslam-Nawara Eslam-Nawara self-assigned this May 20, 2024
@Eslam-Nawara Eslam-Nawara moved this to In Progress in 3.15.x May 20, 2024
@Eslam-Nawara Eslam-Nawara removed the status in 3.15.x May 20, 2024
@Eslam-Nawara Eslam-Nawara removed their assignment May 20, 2024
@rawdaGastan rawdaGastan added this to the later milestone May 22, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jun 11, 2024

@A-Harby
Copy link
Contributor

A-Harby commented Jun 11, 2024

But the node priority needs a validation on the node ID to check if it is on the same farm or not.

Farm 180 doesn't have node 291.

farm_id: 180
included_nodes:
  - 26
  - 28
  - 29
excluded_nodes:
  - 27
priority_nodes:
  - 291

The Famerbot is stuck on this error.
image

@rawdaGastan rawdaGastan modified the milestones: later, v0.16.0 Jul 4, 2024
@Eslam-Nawara Eslam-Nawara moved this to Accepted in 3.15.x Jul 28, 2024
@SalmaElsoly SalmaElsoly moved this from Accepted to In Progress in 3.15.x Jul 28, 2024
@SalmaElsoly SalmaElsoly moved this from In Progress to Pending Review in 3.15.x Jul 29, 2024
@SalmaElsoly SalmaElsoly moved this from Pending Review to In Progress in 3.15.x Jul 29, 2024
@SalmaElsoly SalmaElsoly moved this from In Progress to Pending Review in 3.15.x Jul 30, 2024
@SalmaElsoly
Copy link
Contributor

added nodes validation:

  • included, excluded and priority nodes are in the farm
  • priority nodes are subset of included nodes
  • no overlapping nodes between included and excluded
  • no overlapping nodes between priority and excluded

@SalmaElsoly
Copy link
Contributor

  • added never shutdown validation
  • handled case of all nodes of the farm included

@Eslam-Nawara Eslam-Nawara moved this from Pending Review to In Progress in 3.15.x Aug 4, 2024
@github-project-automation github-project-automation bot moved this from In Verification to Done in 3.15.x Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
farmerbot type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

5 participants