-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prio nodes farmerbot #988
Merged
Merged
prio nodes farmerbot #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rawdaGastan
requested review from
muhamadazmy,
MarioBassem,
ashraffouda,
Omarabdul3ziz,
AbdelrahmanElawady,
xmonader,
sameh-farouk and
Eslam-Nawara
as code owners
April 21, 2024 14:24
rawdaGastan
force-pushed
the
development_prio_nodes_farmerbot
branch
from
April 21, 2024 14:46
1ac66a4
to
3030d5c
Compare
rawdaGastan
force-pushed
the
development_prio_nodes_farmerbot
branch
from
April 21, 2024 15:10
3030d5c
to
1d0e8cc
Compare
rawdaGastan
force-pushed
the
development_prio_nodes_farmerbot
branch
from
April 21, 2024 15:14
1d0e8cc
to
974ffea
Compare
Should we use a slice of nodes instead of a map? |
I think yes, looping over map, saving the keys in array then depending on the order of the keys this won't guarantee the order of the keys to be as expected either |
…f github.com:threefoldtech/tfgrid-sdk-go into development_prio_nodes_farmerbot
…into development_prio_nodes_farmerbot
rawdaGastan
force-pushed
the
development_prio_nodes_farmerbot
branch
from
May 8, 2024 15:04
3ab4dd4
to
85f58fd
Compare
rawdaGastan
force-pushed
the
development_prio_nodes_farmerbot
branch
from
May 8, 2024 15:08
85f58fd
to
c12c9ff
Compare
… power and update, add reset function for reseting nodes and farm in test
…into development_prio_nodes_farmerbot
Eslam-Nawara
approved these changes
May 14, 2024
xmonader
reviewed
May 16, 2024
xmonader
approved these changes
May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues