Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prio nodes farmerbot #988

Merged
merged 11 commits into from
May 19, 2024
Merged

prio nodes farmerbot #988

merged 11 commits into from
May 19, 2024

Conversation

rawdaGastan
Copy link
Collaborator

Related Issues

@rawdaGastan rawdaGastan force-pushed the development_prio_nodes_farmerbot branch from 1ac66a4 to 3030d5c Compare April 21, 2024 14:46
@rawdaGastan rawdaGastan changed the title Development prio nodes farmerbot prio nodes farmerbot Apr 21, 2024
@rawdaGastan rawdaGastan force-pushed the development_prio_nodes_farmerbot branch from 3030d5c to 1d0e8cc Compare April 21, 2024 15:10
@rawdaGastan rawdaGastan force-pushed the development_prio_nodes_farmerbot branch from 1d0e8cc to 974ffea Compare April 21, 2024 15:14
@rawdaGastan
Copy link
Collaborator Author

rawdaGastan commented Apr 21, 2024

Should we use a slice of nodes instead of a map?

farmerbot/README.md Outdated Show resolved Hide resolved
farmerbot/internal/power.go Outdated Show resolved Hide resolved
@Eslam-Nawara
Copy link
Contributor

Should we use a slice of nodes instead of a map?

I think yes, looping over map, saving the keys in array then depending on the order of the keys this won't guarantee the order of the keys to be as expected either

…f github.com:threefoldtech/tfgrid-sdk-go into development_prio_nodes_farmerbot
@rawdaGastan rawdaGastan marked this pull request as draft May 7, 2024 11:29
@rawdaGastan rawdaGastan force-pushed the development_prio_nodes_farmerbot branch from 3ab4dd4 to 85f58fd Compare May 8, 2024 15:04
@rawdaGastan rawdaGastan force-pushed the development_prio_nodes_farmerbot branch from 85f58fd to c12c9ff Compare May 8, 2024 15:08
@rawdaGastan rawdaGastan marked this pull request as ready for review May 8, 2024 15:10
farmerbot/internal/state.go Outdated Show resolved Hide resolved
farmerbot/internal/farmerbot.go Outdated Show resolved Hide resolved
farmerbot/internal/find_node_test.go Outdated Show resolved Hide resolved
… power and update, add reset function for reseting nodes and farm in test
@xmonader xmonader merged commit 65791e6 into development May 19, 2024
39 checks passed
@xmonader xmonader deleted the development_prio_nodes_farmerbot branch May 19, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants