Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sidebar in case the user is not logged in #1314

Closed
AhmedHanafy725 opened this issue Oct 30, 2023 · 9 comments
Closed

Show sidebar in case the user is not logged in #1314

AhmedHanafy725 opened this issue Oct 30, 2023 · 9 comments
Assignees
@zaelgohary
Labels
playground type_feature New feature or request
Milestone
2.3.0

Comments

@AhmedHanafy725
Copy link
Contributor

ask the user to log in if he selects

  • portal
  • solutions
  • contracts

also disable the user balance in calculator in case the user is not logged in
image
@AhmedHanafy725 AhmedHanafy725 added type_feature New feature or request playground labels Oct 30, 2023
@AhmedHanafy725 AhmedHanafy725 added this to the 2.3.0 milestone Oct 30, 2023
@xmonader xmonader moved this to Accepted in 3.13.x Nov 5, 2023
@zaelgohary zaelgohary self-assigned this Nov 5, 2023
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.13.x Nov 5, 2023
@zaelgohary zaelgohary mentioned this issue Nov 5, 2023
Merged
5 tasks
@zaelgohary
Copy link
Contributor

The sidebar is now shown even if not logged in but used can navigate to certain pages. PR is ready for review.

@maayarosama maayarosama mentioned this issue Nov 5, 2023
Closed
@maayarosama maayarosama moved this from In Progress to In review in 3.13.x Nov 6, 2023
@maayarosama maayarosama moved this from In review to In Progress in 3.13.x Nov 6, 2023
@zaelgohary
Copy link
Contributor

Now calculator is broken because the grid is not defined. Will look for a fix tom.

@zaelgohary
Copy link
Contributor

Blocked on #996

@zaelgohary zaelgohary moved this from In Progress to Blocked in 3.13.x Nov 9, 2023
@AhmedHanafy725 AhmedHanafy725 mentioned this issue Nov 22, 2023
Open
@zaelgohary
Copy link
Contributor

The issue is Blocked on #966 as mentioned in the previous comment. However, as a temporary solution, we can either hide the calculator from the menu for now till it's no longer blocked or copy the same calculator module in the playground which I don't recommend.

@zaelgohary zaelgohary mentioned this issue Dec 6, 2023
Closed
@AhmedHanafy725 AhmedHanafy725 moved this from Blocked to Accepted in 3.13.x Dec 7, 2023
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.13.x Dec 7, 2023
@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.13.x Dec 7, 2023
@mohamedamer453 mohamedamer453 mentioned this issue Dec 10, 2023
Closed
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.13.x Dec 10, 2023
@zaelgohary
Copy link
Contributor

WIP:
Implementing calculator methods inside Playground for now. They'll be removed once the #966 is done.

@zaelgohary
Copy link
Contributor

WIP:
Added calculator module but the calculator page showing some errors so I'm working on them.

@zaelgohary zaelgohary moved this from In Progress to Pending Deployment in 3.13.x Dec 12, 2023
@zaelgohary zaelgohary moved this from Pending Deployment to Pending review in 3.13.x Dec 12, 2023
@zaelgohary
Copy link
Contributor

Work completed:
Applied implemented calculator in resources pricing. The calculator can now be used with or without login.

@zaelgohary zaelgohary moved this from Pending review to In Progress in 3.13.x Dec 17, 2023
@zaelgohary zaelgohary moved this from In Progress to Pending review in 3.13.x Dec 17, 2023
@zaelgohary zaelgohary moved this from Pending review to In Verification in 3.13.x Dec 18, 2023
@khaledyoussef24
Copy link
Contributor

environment used :devnet
verified calculator now can be used with or without login
Screencast from 12-18-2023 02:10:14 PM.webm
same for all of the dashboard components
but he asks only for to log in with wallets to process anything more

testlodge :https://app.testlodge.com/a/26076/projects/40893/suites/234374?expand_section=422331#case_4155946

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.13.x Dec 18, 2023
@ramezsaeed
Copy link
Contributor

Verified:

Screenshot from 2023-12-25 14-29-44
Screenshot from 2023-12-25 14-29-39
Screenshot from 2023-12-25 14-29-33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaelgohary zaelgohary

Labels
playground type_feature New feature or request
Projects
No open projects
3.13.x
Status: Done
Milestone
2.3.0
Development

No branches or pull requests
4 participants
@ramezsaeed @zaelgohary @AhmedHanafy725 @khaledyoussef24