Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show sidebar if the user is not logged in #1364

Merged
merged 13 commits into from
Dec 18, 2023
Merged

Show sidebar if the user is not logged in #1364

merged 13 commits into from
Dec 18, 2023

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Nov 5, 2023 •
edited
Loading

Description

  • Now user can navigate all pages except for portal, solutions & contracts if not logged in
  • Disabled calculate w user balance if not logged in

image

image

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary changed the base branch from development to development_313 November 5, 2023 10:04
@AhmedHanafy725 AhmedHanafy725 changed the title Development show nav Show sidebar if the user is not logged in Nov 5, 2023
@AhmedHanafy725
Copy link
Contributor

the calculator is broken when the user is not logged in

image

@zaelgohary zaelgohary marked this pull request as draft November 6, 2023 19:09
Base automatically changed from development_313 to development December 6, 2023 11:24
@zaelgohary zaelgohary marked this pull request as ready for review December 12, 2023 10:48
mohamedamer453
mohamedamer453 reviewed Dec 12, 2023
View reviewed changes
Copy link
Contributor

@mohamedamer453 mohamedamer453 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • When the screen in minimized, the icon for opening the sidebar appears but it's disabled.

    image

  • Nodes and farms are not shown if the user isn't logged in. i think both should be shown since they contain data that the user might need without logging in.

  • Deployment cost from the pricing calculator is completely different when the user is logged out.

    • logged out

      image

    • logged in

      image

@zaelgohary
Copy link
Contributor Author

zaelgohary commented Dec 12, 2023 •
edited
Loading

@mohamedamer453 I fixed the sidebar btn. As for the calculations, I tried when logged in or not and got the same result as seen below. Can you tell me the scenario you tried?

Logged in:
image

Logged out:
image

@mohamedamer453
Copy link
Contributor

@mohamedamer453 I fixed the sidebar btn. As for the calculations, I tried when logged in or not and got the same result as seen below. Can you tell me the scenario you tried?

No specific scenario, i just used the calculator while logged out and i got different values.

image

@AlaaElattar
Copy link
Contributor

AlaaElattar commented Dec 17, 2023 •
edited
Loading

  • The color of cards not and prices changed.
Screencast.from.12-17-2023.11.19.41.AM.webm

@AlaaElattar
Copy link
Contributor

  • cards are not available

image

@AlaaElattar
Copy link
Contributor

  • when i type smth in balance while I'm logged out, it doesn't reflect in cards. Is that intentional ??

@zaelgohary zaelgohary marked this pull request as draft December 17, 2023 11:01
@zaelgohary zaelgohary marked this pull request as ready for review December 17, 2023 12:42
@amiraabouhadid
Copy link
Contributor

when i log in then log out i get this error in the calculator and the calculated costs are still shown even though i logged out
image

@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Dec 17, 2023 •
edited
Loading

wouldn't it be better if we displayed a message to the user if he/she selects user farms or any other page that isnt available before login? A message like "Please login to view page"? Otherwise it feels counter intuitive to be redirected to pages but still get the same welcome screen.

@AlaaElattar
Copy link
Contributor

Should calculator work when user logs out or not ?

@zaelgohary
Copy link
Contributor Author

Should calculator work when user logs out or not ?

Yes.

@zaelgohary
Copy link
Contributor Author

when i log in then log out i get this error in the calculator and the calculated costs are still shown even though i logged out image

Calculator is supposed to be shown whether the user is logged in or not. I tried now and couldn't find the error shown in the console. Can you try again?

@zaelgohary
Copy link
Contributor Author

wouldn't it be better if we displayed a message to the user if he/she selects user farms or any other page that isnt available before login? A message like "Please login to view page"? Otherwise it feels counter intuitive to be redirected to pages but still get the same welcome screen.

done.

@AlaaElattar
Copy link
Contributor

  • Why the value change once i log out ??
Screencast.from.12-17-2023.05.04.23.PM.webm

AlaaElattar
AlaaElattar approved these changes Dec 17, 2023
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Great Job

@zaelgohary zaelgohary merged commit 6f514d7 into development Dec 18, 2023
@zaelgohary zaelgohary deleted the development_show_nav branch December 18, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mohamedamer453 mohamedamer453 mohamedamer453 left review comments

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @AhmedHanafy725 @mohamedamer453 @AlaaElattar @amiraabouhadid