Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zmachine unit tests #2458

Closed
Tracked by #2352
zaelgohary opened this issue Mar 18, 2024 · 4 comments
Closed
Tracked by #2352

Add zmachine unit tests #2458

zaelgohary opened this issue Mar 18, 2024 · 4 comments
Assignees
@zaelgohary
Labels
type_feature New feature or request
Milestone
2.6.0

Comments

@zaelgohary
Copy link
Contributor

zaelgohary commented Mar 18, 2024 •
edited
Loading

Which package/s are you suggesting this feature for?

grid_client

Describe the solution you'd like

Add tests for zmachine.ts
@zaelgohary zaelgohary added the type_feature New feature or request label Mar 18, 2024
@zaelgohary zaelgohary mentioned this issue Mar 18, 2024
Open
14 tasks
@AhmedHanafy725 AhmedHanafy725 modified the milestones: 2.4.0, 2.6.0 Mar 24, 2024
@AhmedHanafy725 AhmedHanafy725 removed this from 3.14.x May 29, 2024
@zaelgohary zaelgohary self-assigned this Jun 6, 2024
@zaelgohary zaelgohary moved this to In Progress in 3.15.x Jun 6, 2024
@zaelgohary
Copy link
Contributor Author

WIP:

Working on adding tests on all Zmachine fields.

@zaelgohary zaelgohary moved this from In Progress to Accepted in 3.15.x Jun 9, 2024
@zaelgohary zaelgohary moved this from Accepted to In Progress in 3.15.x Jun 25, 2024
@zaelgohary zaelgohary mentioned this issue Jun 26, 2024
Merged
5 tasks
@zaelgohary zaelgohary moved this from In Progress to Pending Review in 3.15.x Jun 26, 2024
@zaelgohary
Copy link
Contributor Author

Work completed:

Added tests.

@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.15.x Jun 27, 2024
@khaledyoussef24
Copy link
Contributor

the test is failing is there something missing shall i add ?

Image
Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Accepted in 3.15.x Jul 31, 2024
@zaelgohary zaelgohary mentioned this issue Jul 31, 2024
Merged
5 tasks
@zaelgohary zaelgohary moved this from Accepted to Pending Review in 3.15.x Jul 31, 2024
@A-Harby A-Harby mentioned this issue Aug 18, 2024
Closed
1 task
@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.15.x Aug 25, 2024
@khaledyoussef24
Copy link
Contributor

verified and tested and working fine

Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Aug 27, 2024
@khaledyoussef24 khaledyoussef24 mentioned this issue Aug 27, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zaelgohary zaelgohary

Labels
type_feature New feature or request
Projects
3.15.x
Status: Done
Milestone
2.6.0
Development

No branches or pull requests
4 participants
@ramezsaeed @zaelgohary @AhmedHanafy725 @khaledyoussef24