Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Zmachine tests #3186

Merged
merged 9 commits into from
Aug 25, 2024
Merged

Fix Zmachine tests #3186

merged 9 commits into from
Aug 25, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jul 31, 2024 •
edited
Loading

Description

  • Tests were passing before because compute capacity class wasn't validated. Edited zmachine tests & validated its workload

image

Changes

  • Fix zmachine tests
  • Add more tests
  • Validate zmachine workload

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

AhmedHanafy725
AhmedHanafy725 requested changes Jul 31, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the tests are not enough, we can test every property on the zmachine workload.

we can even write json workload and try to cast it on the class to test the data type

@AhmedHanafy725
Copy link
Contributor

please use better title for the PR

@zaelgohary zaelgohary changed the title Development_zmachine_test Fix Zmachine tests Jul 31, 2024
@Mahmoud-Emad
Copy link
Contributor

Please resolve the conflicts

@zaelgohary
Copy link
Contributor Author

Please resolve the conflicts

Done.

@AhmedHanafy725
Copy link
Contributor

I think the tests are not enough, we can test every property on the zmachine workload.

still we can add more tests

@zaelgohary zaelgohary marked this pull request as draft August 8, 2024 12:51
@zaelgohary zaelgohary marked this pull request as ready for review August 13, 2024 05:00
@zaelgohary zaelgohary marked this pull request as draft August 14, 2024 07:02
@zaelgohary zaelgohary marked this pull request as ready for review August 14, 2024 08:02
AhmedHanafy725
AhmedHanafy725 reviewed Aug 25, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you may think about more edge cases

@zaelgohary zaelgohary merged commit b00d6f5 into development Aug 25, 2024
9 checks passed
@zaelgohary zaelgohary deleted the development_zmachine_test branch August 25, 2024 14:26
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @AhmedHanafy725 @Mahmoud-Emad @0oM4R @xmonader