Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review the solutions domain, it needs to be shorter #2571

Closed
Mahmoud-Emad opened this issue Apr 16, 2024 · 2 comments
Closed

Review the solutions domain, it needs to be shorter #2571

Mahmoud-Emad opened this issue Apr 16, 2024 · 2 comments
Assignees
Labels
type_feature New feature or request
Milestone

Comments

@Mahmoud-Emad
Copy link
Contributor

Which package/s are you suggesting this feature for?

Dashboard

Is your feature request related to a problem? Please describe

it's a part of #2564

Describe the solution you'd like

The solutions domain needs a review to check the generated domain name, it should be only the solution prefix + the solution name.

@Mahmoud-Emad Mahmoud-Emad added the type_feature New feature or request label Apr 16, 2024
@Mahmoud-Emad Mahmoud-Emad moved this to Accepted in 3.14.x Apr 16, 2024
@Mahmoud-Emad Mahmoud-Emad added this to the 2.5.0 milestone Apr 16, 2024
@zaelgohary zaelgohary self-assigned this Apr 30, 2024
@zaelgohary
Copy link
Contributor

Should be fixed here

@zaelgohary zaelgohary moved this from Accepted to Pending Review in 3.14.x Apr 30, 2024
@zaelgohary zaelgohary moved this from Pending Review to In Verification in 3.14.x May 9, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Jun 3, 2024

Verified, in #2564 (comment).
The name given to the domain is a combination of solution type, twin ID, solution name, and a random character.

@A-Harby A-Harby moved this from In Verification to Done in 3.14.x Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type_feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants