Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Items per page in all tables should be consistent #2746

Closed
1 task done
AlaaElattar opened this issue May 21, 2024 · 11 comments
Closed
1 task done

🐞 [Bug]: Items per page in all tables should be consistent #2746

AlaaElattar opened this issue May 21, 2024 · 11 comments
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@AlaaElattar
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

  • Items per page for farm finder page, not consistent with rest of tables

image

Steps To Reproduce

1- Open Dashboard
2- Navigate to farm finder

which network/s did you face the problem on?

Dev

version

Twin ID/s

Node ID/s

Farm ID/s

Contract ID/s

Relevant screenshots/screen records

Relevant log output

-
@AlaaElattar AlaaElattar added the type_bug Something isn't working label May 21, 2024
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone May 27, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.15.x May 27, 2024
@samaradel samaradel self-assigned this Jun 10, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Jun 10, 2024
@samaradel samaradel mentioned this issue Jun 10, 2024
5 tasks
@samaradel
Copy link
Contributor

Work Completed:

Fix farm finder table pagination

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Jun 10, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.15.x Jun 11, 2024
@khaledyoussef24
Copy link
Contributor

Image
Image

still the same issue is found how is set as a default 20 while 20 is not an option to choose

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Accepted in 3.15.x Jul 8, 2024
@khaledyoussef24
Copy link
Contributor

same for your farms page

Image

@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Jul 10, 2024
@samaradel
Copy link
Contributor

Work Completed:

Rest all data-tables paginations to the default value.

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Jul 14, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.15.x Jul 16, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Jul 16, 2024
@samaradel
Copy link
Contributor

Work Completed:

Remove All option from pagination as it's not supported yet.

@samaradel samaradel moved this from Pending Review to In Verification in 3.15.x Jul 16, 2024
@khaledyoussef24
Copy link
Contributor

khaledyoussef24 commented Jul 24, 2024

verified and options in the farm finder and the node finder are consistent for now

Image
Image
Image
Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Jul 24, 2024
@ramezsaeed ramezsaeed moved this from Done to In Verification in 3.15.x Aug 7, 2024
@khaledyoussef24
Copy link
Contributor

@samaradel is there is another issue for this or this will be removed ?

@samaradel
Copy link
Contributor

@khaledyoussef24 idk, maybe it was updated recently

@khaledyoussef24
Copy link
Contributor

Ite,s on deployment list are still different than others :

Image

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Accepted in 3.15.x Aug 12, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Aug 13, 2024
@samaradel
Copy link
Contributor

Work completed:

Make all deployment tables consistent

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Aug 13, 2024
@AhmedHanafy725 AhmedHanafy725 moved this from Pending Review to In Verification in 3.15.x Aug 14, 2024
@khaledyoussef24
Copy link
Contributor

verifed on devnet
version : a542a73

all items per page are now consistent

Image

Image

test case

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants