Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make all datatables paginations consistent #3119

Merged
merged 3 commits into from
Jul 16, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Jul 14, 2024

Description

Make all data-table paginations consistent.

Changes

Rest all data-tables paginations to the default value.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Some tables have default not in the list
    image
  • Please remove All as it's not supported.

@samaradel samaradel marked this pull request as draft July 16, 2024 13:12
@samaradel samaradel marked this pull request as ready for review July 16, 2024 13:18
@samaradel samaradel merged commit 204298c into development Jul 16, 2024
4 checks passed
@samaradel samaradel deleted the development_datatables branch July 16, 2024 13:40
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants