Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: filter node result in nodes that don't have enough resource #2750

Closed
1 task done
A-Harby opened this issue May 21, 2024 · 5 comments
Closed
1 task done
Assignees
Labels
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented May 21, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

grid_client

What happened?

I have been getting this error a lot lately, more than it's supposed. I use a filter node to find a node with a specific resource, and when deploying on one of these nodes, it gave an error that the node doesn't have enough resources, which doesn't make much sense.

filter node result in nodes that don't have enough resource

It has been happening in most of the scripts and also in workflows, and it's usually node 11.

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

5856083

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

image
image
image

Relevant log output

.
@Mahmoud-Emad
Copy link
Contributor

Mahmoud-Emad commented May 30, 2024

Issue update

Work in progress

Could be related to threefoldtech/tfgrid-sdk-go#1052 or threefoldtech/zos#2351

@Omarabdul3ziz
Copy link
Contributor

check the updates on the linked issues please

@Mahmoud-Emad
Copy link
Contributor

Based on @AhmedHanafy725

it requires that the scripts to use the filters correctly.
for example: if I require a vm with a disk, I should consider that ssd required for this deployment to be the added disk + rootfs
what I can see is we only consider the disk in the filters, but the client before executing the deployment, it double checks that and I believe that's why it fails

@A-Harby Please update the scripts

@Mahmoud-Emad Mahmoud-Emad moved this from Blocked to In Verification in 3.14.x Jun 5, 2024
@A-Harby A-Harby moved this from In Verification to In Progress in 3.14.x Jun 5, 2024
@A-Harby A-Harby assigned A-Harby and unassigned Mahmoud-Emad Jun 5, 2024
@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 5, 2024

#2874

@amiraabouhadid amiraabouhadid moved this from In Progress to Pending Review in 3.14.x Jun 5, 2024
@A-Harby
Copy link
Contributor Author

A-Harby commented Jun 6, 2024

Done, #2874.

@A-Harby A-Harby moved this from Pending Review to Done in 3.14.x Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

4 participants