-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the peertube, mattermost, funkwhale, and casperlabs scripts to deploy an instance from the GridClient. #2743
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job ya 7arbii
|
@Mahmoud-Emad I updated the code as requested and tried to match resource on every application with one used on dashboard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small comments :)
I made the requested changes, could you please review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@A-Harby Really nice work! Just one comment. I suggest you downgrade the resources a bit. Maybe we can use the small package (CPU: 1 vCores, Memory: 2 GB, SSD: 15 GB)
as there are not enough resources in devnet ATM. We can add the previous values in an object and use them in the vms instead of using static data. This applies to all solutions in the PR.
I will add the capacity object; I really liked the idea of changing it only in one place, but for the values, I used the same values as the small capacity package for every solution, like: https://www.manual.grid.tf/documentation/dashboard/solutions/funkwhale.html. I think it would be better to follow the recommended capacity package for every solution, so what do you think? |
Even better. Please, do. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, @A-Harby!
I tried to ssh to the created Mattermost instance but I couldn't. Also, I couldn't find the instance listed in the node contracts so I unlock its contract although it's listed in the mattermost deployment table. Update: I created another instance and I could ssh and access the deployment through the domain. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Harby, Go ahead :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add the scripts for the applications (peertube, mattermost, funkwhale, and casperlabs).
The scripts are ready and working.
Related Issues
#1841
Checklist