Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the peertube, mattermost, funkwhale, and casperlabs scripts to deploy an instance from the GridClient. #2743

Merged
merged 8 commits into from
May 23, 2024

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented May 20, 2024

Description

Add the scripts for the applications (peertube, mattermost, funkwhale, and casperlabs).

The scripts are ready and working.

Related Issues

#1841

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
Copy link
Contributor

After running the script, I got this error
image

the error message: Node 11 doesn't have enough resources: sru=50, mru=2 . while you filter with the required resources, is this issue reported?

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya 7arbii

packages/grid_client/scripts/applications/casberlabs.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/casberlabs.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/casberlabs.ts Outdated Show resolved Hide resolved
@A-Harby
Copy link
Contributor Author

A-Harby commented May 21, 2024

After running the script, I got this error
the error message: Node 11 doesn't have enough resources: sru=50, mru=2 . while you filter with the required resources, is this issue reported?

#2750

@A-Harby A-Harby requested a review from Mahmoud-Emad May 21, 2024 09:53
@A-Harby
Copy link
Contributor Author

A-Harby commented May 21, 2024

Good job ya 7arbii

@Mahmoud-Emad I updated the code as requested and tried to match resource on every application with one used on dashboard.
And also add pingnode function to utils.

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments :)

packages/grid_client/scripts/utils.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/peertube.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/peertube.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/utils.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/utils.ts Show resolved Hide resolved
packages/grid_client/scripts/applications/peertube.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/mattermost.ts Outdated Show resolved Hide resolved
@A-Harby
Copy link
Contributor Author

A-Harby commented May 21, 2024

Small comments :)

I made the requested changes, could you please review it again?

@A-Harby A-Harby requested a review from Mahmoud-Emad May 21, 2024 12:32
@A-Harby A-Harby changed the title Add the scripts for the applications Add the peertube, mattermost, funkwhale, and casperlabs scripts to deploy an instance from the GridClient. May 22, 2024
@A-Harby A-Harby requested a review from Mahmoud-Emad May 22, 2024 09:16
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@A-Harby Really nice work! Just one comment. I suggest you downgrade the resources a bit. Maybe we can use the small package (CPU: 1 vCores, Memory: 2 GB, SSD: 15 GB) as there are not enough resources in devnet ATM. We can add the previous values in an object and use them in the vms instead of using static data. This applies to all solutions in the PR.

@A-Harby
Copy link
Contributor Author

A-Harby commented May 22, 2024

@A-Harby Really nice work! Just one comment. I suggest you downgrade the resources a bit. Maybe we can use the small package (CPU: 1 vCores, Memory: 2 GB, SSD: 15 GB) as there are not enough resources in devnet ATM. We can add the previous values in an object and use them in the vms instead of using static data. This applies to all solutions in the PR.

I will add the capacity object; I really liked the idea of changing it only in one place, but for the values, I used the same values as the small capacity package for every solution, like: https://www.manual.grid.tf/documentation/dashboard/solutions/funkwhale.html.

I think it would be better to follow the recommended capacity package for every solution, so what do you think?

@zaelgohary
Copy link
Contributor

I think it would be better to follow the recommended capacity package for every solution, so what do you think?

Even better. Please, do.

@A-Harby A-Harby requested a review from zaelgohary May 22, 2024 10:41
zaelgohary
zaelgohary previously approved these changes May 22, 2024
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @A-Harby!

@zaelgohary zaelgohary dismissed their stale review May 22, 2024 13:23

Needs some adjustments.

@zaelgohary
Copy link
Contributor

zaelgohary commented May 22, 2024

I tried to ssh to the created Mattermost instance but I couldn't.

image

image

image

Also, I couldn't find the instance listed in the node contracts so I unlock its contract although it's listed in the mattermost deployment table.

image

Update:

I created another instance and I could ssh and access the deployment through the domain.

image

image

image

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case of Funkwhale, I was able to access the domain and login successfully. However, I couldn't ssh to the instance.

image

image

image

@A-Harby
Copy link
Contributor Author

A-Harby commented May 22, 2024

  1. For the Funkwhale SSH issue, it's an actual issue from the image itself, and it's reported here.

  2. For listing contracts, it took a while to list, but it worked with me on both mattermost and Funkwhale.
    image

  3. For Mattermost SSH, it worked fine.
    image

@A-Harby A-Harby requested a review from zaelgohary May 22, 2024 16:29
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Harby, Go ahead :)

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@A-Harby A-Harby merged commit e45b0f9 into development May 23, 2024
2 checks passed
@A-Harby A-Harby deleted the development_add_applications_scripts branch May 23, 2024 08:04
@A-Harby A-Harby mentioned this pull request Aug 21, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants