Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add static website script #3325

Merged
merged 4 commits into from
Aug 25, 2024
Merged

Add static website script #3325

merged 4 commits into from
Aug 25, 2024

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented Aug 20, 2024

Description

Add the static website example script.

Changes

static website ts.

Related Issues

#2785

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@A-Harby A-Harby marked this pull request as draft August 20, 2024 17:04
@A-Harby A-Harby marked this pull request as ready for review August 20, 2024 17:06
@A-Harby A-Harby mentioned this pull request Aug 20, 2024
Closed
Mahmoud-Emad
Mahmoud-Emad requested changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya 7arbii

packages/grid_client/scripts/applications/static_website.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/applications/static_website.ts Outdated Show resolved Hide resolved
khaledyoussef24
khaledyoussef24 approved these changes Aug 25, 2024
View reviewed changes
Copy link
Contributor

@khaledyoussef24 khaledyoussef24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job harby

@A-Harby A-Harby merged commit 1dd8e27 into development Aug 25, 2024
9 checks passed
@A-Harby A-Harby deleted the development_add_static_website_script branch August 25, 2024 07:34
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@khaledyoussef24 khaledyoussef24 khaledyoussef24 approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@A-Harby @Mahmoud-Emad @khaledyoussef24 @xmonader