Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Update DeleteMachineModel.DeploymentData validation #3314

Closed
1 task done
0oM4R opened this issue Aug 19, 2024 · 4 comments
Closed
1 task done

🐞 [Bug]: Update DeleteMachineModel.DeploymentData validation #3314

0oM4R opened this issue Aug 19, 2024 · 4 comments
Assignees
Labels
grid_client type_bug Something isn't working
Milestone

Comments

@0oM4R
Copy link
Contributor

0oM4R commented Aug 19, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

I can't delete a deployment with name Ofe_tea09

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

2.5.2

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

Screenshot from 2024-08-19 12-29-55

Relevant log output

Error while deleting deployment ValidationError: Validation failed. errors: An instance of DeleteMachineModel has failed the validation:
 - property deployment_name has failed the following constraints: isAlphanumeric 
.
@0oM4R 0oM4R added type_bug Something isn't working grid_client labels Aug 19, 2024
@AhmedHanafy725
Copy link
Contributor

related to #2364

@AhmedHanafy725 AhmedHanafy725 added this to the 2.6.0 milestone Aug 28, 2024
@AhmedHanafy725 AhmedHanafy725 moved this to Accepted in 3.15.x Aug 28, 2024
@0oM4R 0oM4R self-assigned this Sep 1, 2024
@0oM4R 0oM4R moved this from Accepted to In Progress in 3.15.x Sep 1, 2024
@0oM4R 0oM4R moved this from In Progress to Pending Review in 3.15.x Sep 1, 2024
@0oM4R 0oM4R moved this from Pending Review to In Verification in 3.15.x Sep 2, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Sep 2, 2024

Devnet, 99b5130.

I am still getting the same error!

screen-capture.5.webm

image

Validation failed. errors: Array(1) [Object(5) {"target": Object(2) {"name": test_omar, "deployment_name": test_omar}, "value": test_omar, "property": deployment_name, "children": Array(0) [], "constraints": Object(1) {"isAlphanumeric": deployment_name must contain only letters and numbers}}]

Error while deleting deployment ValidationError: Validation failed. errors: An instance of DeleteMachineModel has failed the validation:
- property deployment_name has failed the following constraints: isAlphanumeric 
.

error while getting value of key(VM89c30eb6) GridClientError: Couldn't decrypt key: dev/162/machines/fullvm/VM89c30eb6/contracts.json.

@A-Harby A-Harby moved this from In Verification to Accepted in 3.15.x Sep 2, 2024
@0oM4R
Copy link
Contributor Author

0oM4R commented Sep 2, 2024

Devnet, 99b5130.

I am still getting the same error!

screen-capture.5.webm
image

Validation failed. errors: Array(1) [Object(5) {"target": Object(2) {"name": test_omar, "deployment_name": test_omar}, "value": test_omar, "property": deployment_name, "children": Array(0) [], "constraints": Object(1) {"isAlphanumeric": deployment_name must contain only letters and numbers}}]

Error while deleting deployment ValidationError: Validation failed. errors: An instance of DeleteMachineModel has failed the validation:
- property deployment_name has failed the following constraints: isAlphanumeric 
.

error while getting value of key(VM89c30eb6) GridClientError: Couldn't decrypt key: dev/162/machines/fullvm/VM89c30eb6/contracts.json.

the mentioned version is earlier commit
please validate it on newer version 95f7469

@0oM4R 0oM4R moved this from Accepted to In Verification in 3.15.x Sep 2, 2024
@0oM4R 0oM4R moved this from In Verification to Accepted in 3.15.x Sep 2, 2024
@A-Harby
Copy link
Contributor

A-Harby commented Sep 3, 2024

Verified, Devnet 4829e02.

The deletion worked fine.
image

@A-Harby A-Harby moved this from Accepted to Done in 3.15.x Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
grid_client type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

4 participants