Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 [Bug]: Change mail config validator on taiga #3343

Closed
1 task done
A-Harby opened this issue Aug 28, 2024 · 8 comments
Closed
1 task done

🐞 [Bug]: Change mail config validator on taiga #3343

A-Harby opened this issue Aug 28, 2024 · 8 comments
Assignees
Labels
dashboard type_bug Something isn't working
Milestone

Comments

@A-Harby
Copy link
Contributor

A-Harby commented Aug 28, 2024

Is there an existing issue for this?

  • I have searched the existing issues

which package/s did you face the problem with?

Dashboard

What happened?

The same issue is happing to the taiga, and also check all of the other application stmp.

Steps To Reproduce

No response

which network/s did you face the problem on?

Dev

version

448a213

Twin ID/s

No response

Node ID/s

No response

Farm ID/s

No response

Contract ID/s

No response

Relevant screenshots/screen records

#2152 (comment)

Relevant log output

.
@A-Harby A-Harby added the type_bug Something isn't working label Aug 28, 2024
@ramezsaeed ramezsaeed added this to 3.15.x Sep 5, 2024
@ramezsaeed ramezsaeed added this to the 2.6.0 milestone Sep 5, 2024
@ramezsaeed ramezsaeed changed the title 🐞 [Bug]: Change mail config filters on taiga 🐞 [Bug]: Change mail config validator on taiga Sep 5, 2024
@amiraabouhadid
Copy link
Contributor

amiraabouhadid commented Sep 5, 2024

Use validation used in discourse solution. Remove the condition applying validation to just discourse.
Check after the validation change that the solution won't crash because other solution might inherently have different email requirements.
Check if you can still send emails with SMTP

@amiraabouhadid amiraabouhadid moved this to Accepted in 3.15.x Sep 5, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Sep 8, 2024
@samaradel
Copy link
Contributor

Work in Progress (WIP):

utils created to validate SMTP (email, apiKey, username), faced an error .. investigating..

@samaradel samaradel moved this from In Progress to Accepted in 3.15.x Sep 9, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Sep 10, 2024
@samaradel
Copy link
Contributor

samaradel commented Sep 10, 2024

Work Completed:

  • Remove isDiscourse check and apply adding email or username for all apps with SMTP.
  • Create a function to validate applications with SMTP.
  • All solutions with SMTP are tested except Taiga which is blocked on Taiga: Email not working  tf-images#293

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Sep 10, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.15.x Oct 1, 2024
@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 2, 2024
@samaradel samaradel moved this from Pending Review to In Progress in 3.15.x Oct 2, 2024
@samaradel
Copy link
Contributor

Work Completed:

  • Doc string added to explain the new IsAlphaExpectDashAndUnderscore validator function.
  • Unit test added too.

@samaradel samaradel moved this from In Progress to Pending Review in 3.15.x Oct 2, 2024
@samaradel samaradel moved this from Pending Review to In Verification in 3.15.x Oct 21, 2024
@khaledyoussef24
Copy link
Contributor

verified on devnet
Version a78daae

now user names are allowed so user can use api keys or user name normally
Image
Image

passwords is allowed more than 50 characters
validation is also added (in this case i used space in the user name to test validation ):
Image
here to check that passwords can be more than 50 characters :
Image
here to check the validation of passwords when inserting space :
Image

testcase

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Oct 29, 2024
@khaledyoussef24
Copy link
Contributor

after deploying 2 taigas did not recieve any mails on the mail I used in the setup is this related ?

@khaledyoussef24 khaledyoussef24 moved this from Done to Accepted in 3.15.x Nov 4, 2024
@samaradel samaradel moved this from Accepted to In Progress in 3.15.x Nov 5, 2024
@samaradel
Copy link
Contributor

we mentioned here that taiga part is blocked on threefoldtech/tf-images#293

@samaradel samaradel moved this from In Progress to In Verification in 3.15.x Nov 5, 2024
@khaledyoussef24
Copy link
Contributor

Okay, thanks for clarifying.

@khaledyoussef24 khaledyoussef24 moved this from In Verification to Done in 3.15.x Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard type_bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

5 participants