Developemnt 313 mass deployment #1421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlaaElattar
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
Omarabdul3ziz and
0oM4R
as code owners
…grid-sdk-ts into developemnt_313_mass_deployment
…grid-sdk-ts into developemnt_313_mass_deployment
…grid-sdk-ts into developemnt_313_mass_deployment
AhmedHanafy725
approved these changes
Dec 10, 2023
There was a problem hiding this comment.
Great work! i ran the script locally and from the workflow and both ran without any issues.
There's just a tiny comment, after the script is done the number of successful and failed deployments seems to be inaccurate. as seen from this run on github, the number of successful deployments is 200 and the number of failed ones is 161, and as seen in the script itself the total number of deployments is 250, so i think there's an error with the counting logic.
mohamedamer453
approved these changes
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make mass deployments up to 1000 workload, each batch (100 deployment) will get deployed together to reduce time and not deploying each vm one by one.
Related Issues
#1352