Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grid client: Fix storing redundant keys #200

Merged
merged 1 commit into from
Apr 30, 2023
Merged

grid client: Fix storing redundant keys #200

merged 1 commit into from
Apr 30, 2023

Conversation

AhmedHanafy725
Copy link
Contributor

Description

  • check the network key if it has the same content before storing the new info
  • add a check to not store the same network twin after the deployment is done
  • don't return the contract that contains only the network workload as it's already handled by the deployer.

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings

@AhmedHanafy725 AhmedHanafy725 merged commit 449e720 into development Apr 30, 2023
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_storing_keys branch April 30, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmonader xmonader xmonader approved these changes

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@Omarabdul3ziz Omarabdul3ziz Awaiting requested review from Omarabdul3ziz

Assignees
No one assigned
Labels
grid_client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AhmedHanafy725 @xmonader @Mahmoud-Emad