Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use grid store instead of getGrid #2563

Merged
merged 9 commits into from
May 9, 2024
Merged

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Apr 15, 2024

Changes

  • Use grid store instead of getGrid in all Dashboard pages excepts for profile
  • Remove unused code

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as draft April 18, 2024 08:34
@zaelgohary zaelgohary marked this pull request as ready for review April 21, 2024 09:11
@zaelgohary zaelgohary requested a review from 0oM4R April 21, 2024 09:11
@zaelgohary
Copy link
Contributor Author

Reverted changes in the deployment list as some issues appeared as a result of using the store. The previous issues were solved by reverting the changes.

@zaelgohary zaelgohary requested a review from 0oM4R April 29, 2024 05:13
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@MohamedElmdary
Copy link
Member

These parts are not yet updated

  1. import { getGrid, updateGrid } from "../utils/grid";

  2. import { getGrid, updateGrid } from "../utils/grid";

  3. import SSHKeysManagement from "@/utils/ssh";

  4. import { getGrid, readEmail, storeEmail } from "../utils/grid";

@zaelgohary
Copy link
Contributor Author

@MohamedElmdary Regarding the deployment files, previous comments noted that utilizing the store led to numerous bugs, so we've opted against using it in the listing. As for the remaining files, I'll make the required adjustments.

@zaelgohary zaelgohary merged commit fccd8f5 into development May 9, 2024
3 checks passed
@zaelgohary zaelgohary deleted the development_use_grid_store branch May 9, 2024 09:52
@Mahmoud-Emad Mahmoud-Emad mentioned this pull request May 13, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants