-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the last deployment date on the node details pop up #2688
Merged
AhmedHanafy725
merged 4 commits into
development
from
development_node_details_last_deployment
May 14, 2024
Merged
Add the last deployment date on the node details pop up #2688
AhmedHanafy725
merged 4 commits into
development
from
development_node_details_last_deployment
May 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
May 13, 2024 08:42
Mahmoud-Emad
changed the title
feat: Add the last deployment date on the node details pop up
Add the last deployment date on the node details pop up
May 13, 2024
- Updated the NodeStats interface to include last_deployment_timestamp - Added a new field 'Last Deployment' to the node details card in the dashboard - Display the last deployment timestamp in human-readable format if available
Mahmoud-Emad
force-pushed
the
development_node_details_last_deployment
branch
from
May 13, 2024 08:44
9065152
to
d72d7d1
Compare
Playground build fails. |
…' prop was miising.
Fixed |
packages/playground/src/components/node_details_cards/node_details_card.vue
Outdated
Show resolved
Hide resolved
Maybe the feature is supported only on Devnet https://gridproxy.dev.grid.tf/nodes/11/statistics However, it is good catch, we should display N/A instead |
MohamedElmdary
approved these changes
May 13, 2024
AlaaElattar
approved these changes
May 14, 2024
AhmedHanafy725
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add last deployment timestamp to node details card
Changes
Related Issues
Screenshots/Video
Checklist