Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the last deployment date on the node details pop up #2688

Merged
merged 4 commits into from
May 14, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented May 13, 2024

Description

Add last deployment timestamp to node details card

Changes

  • Updated the NodeStats interface to include last_deployment_timestamp
  • Added a new field 'Last Deployment' to the node details card in the dashboard
  • Display the last deployment timestamp in human-readable format if available

Related Issues

Screenshots/Video

  • image

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad changed the title feat: Add the last deployment date on the node details pop up Add the last deployment date on the node details pop up May 13, 2024
- Updated the NodeStats interface to include last_deployment_timestamp
- Added a new field 'Last Deployment' to the node details card in the dashboard
- Display the last deployment timestamp in human-readable format if available
@Mahmoud-Emad Mahmoud-Emad force-pushed the development_node_details_last_deployment branch from 9065152 to d72d7d1 Compare May 13, 2024 08:44
@zaelgohary
Copy link
Contributor

Playground build fails.

@Mahmoud-Emad
Copy link
Contributor Author

Playground build fails.

Fixed

@MohamedElmdary
Copy link
Member

MohamedElmdary commented May 13, 2024

Checking on different networks

  • devnet

  • qanet
    Error Invalid date
    image

  • testnet
    Error Invalid date
    image

  • mainnet
    Error Invalid date
    image

Expected to get N/A if date is not valid

@Mahmoud-Emad
Copy link
Contributor Author

@AhmedHanafy725 AhmedHanafy725 merged commit 56bd63e into development May 14, 2024
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_node_details_last_deployment branch May 14, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants