Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add limit for node fee and close dialog after success of failure #2693

Merged
merged 3 commits into from
May 14, 2024
Merged

Add limit for node fee and close dialog after success of failure #2693

merged 3 commits into from
May 14, 2024

Conversation

AlaaElattar
Copy link
Contributor

Description

  • The dialog should be closed automatically after updating the fees.
  • There should be max limit for fee

Changes

  • Dialog will close after updating
  • added max limit for fee (max limit accepted by chain)

Related Issues

Screencast.from.05-13-2024.02.25.32.PM.webm

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@AlaaElattar AlaaElattar merged commit eebb938 into development May 14, 2024
3 checks passed
@AlaaElattar AlaaElattar deleted the development_limit_node_fee branch May 14, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlaaElattar @AhmedHanafy725 @maayarosama