-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Can't list deployments #2701
Merged
Merged
Commits on May 15, 2024
-
fix: Fixed the issue with list deployments:
- Created a migration function and modified the moduleName to be 'Fullvm' to list all old VMs with 'Fullvm' type.
Configuration menu - View commit details
-
Copy full SHA for 99f0ac4 - Browse repository at this point
Copy the full SHA 99f0ac4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 96d71a4 - Browse repository at this point
Copy the full SHA 96d71a4View commit details -
fix: fixed an issue happened when listing
- Updated the import of 'BaseModule' in 'migration.ts' to be local dir instead of the dist one to fix the un-exported issue - Flat the array of the contracts then loop over them all - Updated the moduleName after listing the 'Fullvm' to 'vm' again to list the other deployments - Pushed the newly changed contract to the 'newContracts' array to avoid the lag of gql - Updated the 'moduleName' in 'base.ts' to take 'Fullvm' if the 'moduleNames' is undefined
Configuration menu - View commit details
-
Copy full SHA for 9b0dcc5 - Browse repository at this point
Copy the full SHA 9b0dcc5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0baa893 - Browse repository at this point
Copy the full SHA 0baa893View commit details -
Configuration menu - View commit details
-
Copy full SHA for cc42480 - Browse repository at this point
Copy the full SHA cc42480View commit details -
- Removed un-needed 'await' in 'Promise.all()' - Removed un-needed 'await' in returning the 'extrinsics' - Returned the 'module.tfClient.applyAllExtrinsics<Contract>(extrinsics);' without awaiting on it - Moved the update of the moduleName to the 'migrateModule'
Configuration menu - View commit details
-
Copy full SHA for 1b57c64 - Browse repository at this point
Copy the full SHA 1b57c64View commit details
Commits on May 16, 2024
-
- Updated the import of the 'BaseModule' from '@threefold/grid_client' - Moved the update of the 'module.moduleName' to the '_migrateOldFullVMs'
Configuration menu - View commit details
-
Copy full SHA for df49a8c - Browse repository at this point
Copy the full SHA df49a8cView commit details
Commits on May 19, 2024
-
fix: fixed the issue of listing deployments by changing the project N…
…ame to '{project Name}' instead of '{project Name/deployment_name}'.
Configuration menu - View commit details
-
Copy full SHA for 1a684c4 - Browse repository at this point
Copy the full SHA 1a684c4View commit details -
fix(Listing deployments): Updated the 'GridClient/base.ts/getMyContra…
…cts' method with some improvements: - Replaced the 'exact' search with 'contains' algo by adding 'includes' when searching on the 'projectName'. - Introduced a new field 'updatedAt' in the 'GqlNodeContract' type to store the updated time in it. - Added a condition on checking on the 'updatedAt' field to replace the newly added contract with the Gql contract.
Configuration menu - View commit details
-
Copy full SHA for 6d3dc61 - Browse repository at this point
Copy the full SHA 6d3dc61View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.