Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Can't list deployments #2701

Merged
merged 9 commits into from
May 21, 2024
Merged

Commits on May 15, 2024

  1. fix: Fixed the issue with list deployments:

    - Created a migration function and modified the moduleName to be 'Fullvm' to list all old VMs with 'Fullvm' type.
    Mahmoud-Emad committed May 15, 2024
    Configuration menu
    Copy the full SHA
    99f0ac4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    96d71a4 View commit details
    Browse the repository at this point in the history
  3. fix: fixed an issue happened when listing

    - Updated the import of 'BaseModule' in 'migration.ts' to be local dir instead of the dist one to fix the un-exported issue
    - Flat the array of the contracts then loop over them all
    - Updated the moduleName after listing the 'Fullvm' to 'vm' again to list the other deployments
    - Pushed the newly changed contract to the 'newContracts' array to avoid the lag of gql
    - Updated the 'moduleName' in 'base.ts' to take 'Fullvm' if the 'moduleNames' is undefined
    Mahmoud-Emad committed May 15, 2024
    Configuration menu
    Copy the full SHA
    9b0dcc5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    0baa893 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    cc42480 View commit details
    Browse the repository at this point in the history
  6. fix: Apply comments:

    - Removed un-needed 'await' in 'Promise.all()'
    - Removed un-needed 'await' in returning the 'extrinsics'
    - Returned the 'module.tfClient.applyAllExtrinsics<Contract>(extrinsics);' without awaiting on it
    - Moved the update of the moduleName to the 'migrateModule'
    Mahmoud-Emad committed May 15, 2024
    Configuration menu
    Copy the full SHA
    1b57c64 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. fix: Apply comments:

    - Updated the import of the 'BaseModule' from '@threefold/grid_client'
    - Moved the update of the 'module.moduleName' to the '_migrateOldFullVMs'
    Mahmoud-Emad committed May 16, 2024
    Configuration menu
    Copy the full SHA
    df49a8c View commit details
    Browse the repository at this point in the history

Commits on May 19, 2024

  1. fix: fixed the issue of listing deployments by changing the project N…

    …ame to '{project Name}' instead of '{project Name/deployment_name}'.
    Mahmoud-Emad committed May 19, 2024
    Configuration menu
    Copy the full SHA
    1a684c4 View commit details
    Browse the repository at this point in the history
  2. fix(Listing deployments): Updated the 'GridClient/base.ts/getMyContra…

    …cts' method with some improvements:
    
    - Replaced the 'exact' search with 'contains' algo by adding 'includes' when searching on the 'projectName'.
    - Introduced a new field 'updatedAt' in the 'GqlNodeContract' type to store the updated time in it.
    - Added a condition on checking on the 'updatedAt' field to replace the newly added contract with the Gql contract.
    Mahmoud-Emad committed May 19, 2024
    Configuration menu
    Copy the full SHA
    6d3dc61 View commit details
    Browse the repository at this point in the history