Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add currency abstraction #2707

Merged
merged 15 commits into from
May 25, 2024
Merged

Add currency abstraction #2707

merged 15 commits into from
May 25, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented May 15, 2024 •
edited
Loading

Changes

  • Add currency abstraction
  • Add currency script
  • Add currency unit tests
  • Edit validateInput fn to return sync code instead of async

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@zaelgohary zaelgohary marked this pull request as ready for review May 19, 2024 17:33
Mahmoud-Emad
Mahmoud-Emad requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Zainab :)

packages/grid_client/scripts/tft.ts Outdated Show resolved Hide resolved
packages/grid_client/src/modules/models.ts Outdated Show resolved Hide resolved
packages/grid_client/scripts/tft.ts Outdated Show resolved Hide resolved
packages/grid_client/tests/modules/tft.test.ts Outdated Show resolved Hide resolved
@zaelgohary zaelgohary marked this pull request as draft May 20, 2024 08:09
@zaelgohary zaelgohary marked this pull request as ready for review May 20, 2024 12:10
@zaelgohary zaelgohary requested a review from xmonader May 20, 2024 12:10
@Mahmoud-Emad
Copy link
Contributor

Please resolve the conflicts

@zaelgohary
Copy link
Contributor Author

Please resolve the conflicts

Resolved.

Mahmoud-Emad
Mahmoud-Emad approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead!

AlaaElattar
AlaaElattar approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@AlaaElattar AlaaElattar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Job ya zuzu

@zaelgohary zaelgohary marked this pull request as draft May 23, 2024 13:20
@zaelgohary
Rename tft module to currency, add more methods to currency abstract…
d2d78db 
…ion, update script and tests, remove unused model
@zaelgohary zaelgohary marked this pull request as ready for review May 23, 2024 14:34
@zaelgohary zaelgohary requested a review from xmonader May 23, 2024 16:44
@zaelgohary zaelgohary merged commit 873b20a into development May 25, 2024
2 checks passed
@zaelgohary zaelgohary deleted the development_add_tft_class branch May 25, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@xmonader xmonader xmonader approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @Mahmoud-Emad @xmonader @AlaaElattar