Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix farms public IPs table selection #2713

Merged
merged 1 commit into from
May 19, 2024
Merged

Fix farms public IPs table selection #2713

merged 1 commit into from
May 19, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented May 16, 2024 •
edited
Loading

Description

Fix farms public IPs table selection by removing the current data-table and passing props to list-table component.

Changes

Screencast.from.16-05-24.16.54.45.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@samaradel samaradel marked this pull request as ready for review May 16, 2024 13:56
@amiraabouhadid amiraabouhadid merged commit 1622d67 into development May 19, 2024
3 checks passed
@amiraabouhadid amiraabouhadid deleted the development_publicIPs_table branch May 19, 2024 10:57
@0oM4R 0oM4R mentioned this pull request Jun 5, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samaradel @AlaaElattar @Mahmoud-Emad @amiraabouhadid