Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Development edit email #2725

Merged
merged 6 commits into from
May 23, 2024
Merged

Development edit email #2725

merged 6 commits into from
May 23, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented May 19, 2024 •
edited
Loading

Description

  • Check the balance before updating the email.
  • Add a button for canceling the edit.
  • Keep the old email when editing to a new email.

Changes

Screencast.from.22-05-24.17.04.59.webm

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Mahmoud-Emad
Mahmoud-Emad requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya Samar

packages/playground/src/dashboard/twin_view.vue Outdated Show resolved Hide resolved
packages/playground/src/dashboard/twin_view.vue Outdated Show resolved Hide resolved
packages/playground/src/dashboard/twin_view.vue Show resolved Hide resolved
@AlaaElattar
Copy link
Contributor

  • What if i wanna cancel the edit ??
Screencast.from.05-20-2024.04.30.42.PM.webm

@samaradel samaradel marked this pull request as draft May 21, 2024 09:47
@samaradel samaradel marked this pull request as ready for review May 21, 2024 10:57
zaelgohary
zaelgohary reviewed May 22, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @samaradel. Just one comment. While editing the email, the input should contain the current user email if exist. He might want to fix a typo or sth and the current solution would make him rewrite the whole email again.

email.webm

@samaradel samaradel marked this pull request as draft May 22, 2024 11:37
@samaradel samaradel marked this pull request as ready for review May 22, 2024 14:07
Mahmoud-Emad
Mahmoud-Emad approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ya Samar, Go ahead!

@samaradel samaradel merged commit 0d4c652 into development May 23, 2024
3 checks passed
@samaradel samaradel deleted the development_edit_email branch May 23, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@AlaaElattar AlaaElattar AlaaElattar approved these changes

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samaradel @AlaaElattar @zaelgohary @Mahmoud-Emad