Adding a batchSize and applying extrinsics per batch #2728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maayarosama
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
AhmedHanafy725
requested changes
May 20, 2024
There was a problem hiding this comment.
This should be applied to all extrinsic methods not only canceling contracts. I suggest it to be done in utility methods (batch, batchAll) here
| @@ -12,21 +12,37 @@ class Utility { | |||
| @checkConnection | |||
| async batch<T>(extrinsics: ExtrinsicResult<T>[]): Promise<T[]> { | |||
| extrinsics = extrinsics.filter(Boolean); | |||
| const batchSize = 400; | |||
There was a problem hiding this comment.
move this constant outside the method to be global in this module
| @@ -323,6 +323,7 @@ class TFContracts extends Contracts { | |||
| extrinsics.push(await this.cancel({ id })); | |||
| } | |||
| await this.client.applyAllExtrinsics(extrinsics); | |||
|
|
|||
There was a problem hiding this comment.
@maayarosama remove this file as it got no changes
AhmedHanafy725
requested changes
May 27, 2024
AhmedHanafy725
approved these changes
May 27, 2024
amiraabouhadid
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a batch size to batchCancelContracts method. so instead of canceling all contracts at once, they get canceled in batches
Changes
Related Issues
Checklist