Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix naming issue when importing ssh key #2763

Merged
merged 1 commit into from
May 23, 2024
Merged

Fix naming issue when importing ssh key #2763

merged 1 commit into from
May 23, 2024

Conversation

AlaaElattar
Copy link
Contributor

@AlaaElattar AlaaElattar commented May 23, 2024 •
edited
Loading

Description

  • When importing key and add name, while saving it's renamed to the name in key.

Changes

  • Added condition to not extract name from key unless the field is empty

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Screencast.from.05-23-2024.10.50.18.AM.webm

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@AlaaElattar AlaaElattar merged commit 54acee9 into development May 23, 2024
3 checks passed
@AlaaElattar AlaaElattar deleted the development_fix_bug_ssh branch May 23, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mahmoud-Emad Mahmoud-Emad Mahmoud-Emad approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AlaaElattar @AhmedHanafy725 @amiraabouhadid @Mahmoud-Emad