Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve deploy error user experience #2920

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Improve deploy error user experience #2920

merged 3 commits into from
Jun 10, 2024

Conversation

MohamedElmdary
Copy link
Member

@MohamedElmdary MohamedElmdary commented Jun 9, 2024 •
edited
Loading

Description

Improve deploy error user experience

Changes

Improve deploy error user experience

image
image

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Jun 9, 2024
@MohamedElmdary
- feat: Add support for selecting 'highlightOnError'
3de10ae 
- feat: Scroll to logs view when clicking 'deploy'
- feat: Add border around highlighted inputs
@MohamedElmdary MohamedElmdary marked this pull request as ready for review June 9, 2024 12:15
samaradel
samaradel requested changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@samaradel samaradel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK it can't be like this
image
the border is using for the big component like node not for fields.

@MohamedElmdary
Copy link
Member Author

MohamedElmdary commented Jun 9, 2024 •
edited
Loading

AFAIK it can't be like this image the border is using for the big component like node not for fields.

are you sure this issue still there? I can't reproduce it

amiraabouhadid
amiraabouhadid approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works https://www.loom.com/share/ef2111e41f904c79977f1503800f3ce5?sid=756ba6bb-383f-497c-8752-16882a5896c7

@MohamedElmdary MohamedElmdary merged commit 1b19f4f into development Jun 10, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_improve_deploy_error_ux branch June 10, 2024 09:30
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@samaradel samaradel samaradel approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees

@MohamedElmdary MohamedElmdary

Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@MohamedElmdary @samaradel @amiraabouhadid @xmonader