Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Name contracts are acting with weird behavior #2923

Merged
merged 1 commit into from
Jun 9, 2024
Merged

fix: Name contracts are acting with weird behavior #2923

merged 1 commit into from
Jun 9, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

Description

Remove the setters of the contract types at the top of the load function.

Changes

  • Remove the setters of the contract types at the top of the load function

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

amiraabouhadid
amiraabouhadid approved these changes Jun 9, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
https://www.loom.com/share/b8e755e5e88a4e83935069f36bd1812c?sid=47b29523-05db-44ab-9ef4-39f89b4e0e74

@Mahmoud-Emad Mahmoud-Emad merged commit 9ce9f80 into development Jun 9, 2024
3 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_reload_only_requested_contracts branch June 9, 2024 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mahmoud-Emad @amiraabouhadid @maayarosama