-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Gateway IP Resides in the Same Subnet as Node's IP #2963
Ensure Gateway IP Resides in the Same Subnet as Node's IP #2963
Conversation
- Implemented a validation rule ensuring the gateway IP address resides within the same subnet as the node's IP address. - A new validation rule has been added to verify whether the provided IPv4 address is public or private. - A new validation rule has been added to verify whether the provided IPv6 address is public or private.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Updated the 'isPrivateIP' validation rule to validate the prefix len. - Displayed the error message in an alert on the form. - Updated the errors that came from the chain to be user-readable message.
There is a validation on the chain that may validate the prefix length. The value '0' you sent is not valid. This scenario is covered. Also, the error message has been updated to be user-readable, and I have logged the actual error from the chain in the console/logger for developer investigations. |
Do we really need to show the error to the user twice? I think the toast is enough. If the user wants to copy it, he can get it from the logs. |
- Removed the 'Error Alert'. - Updated some messages in the validators.
Description
The gateway must reside within the same IP range (subnet) as the node's IP address to facilitate proper routing. This ensures that the node can effectively communicate and route its traffic through the designated gateway.
Changes
Related Issues
Screenshots
Checklist