Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the available for query from the nodes filters #2975

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Remove the available for query from the nodes filters #2975

merged 1 commit into from
Jun 13, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

Description

Fix the issue of Rentable filter is not working fine

Changes

  • Removed the available_for filter from the URL since it's not needed when requested to get nodes.
  • Removed the profileManager checker since it's not needed

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad Mahmoud-Emad merged commit b4861f5 into development Jun 13, 2024
3 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_remove_available_for_query branch June 13, 2024 08:12
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama maayarosama approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mahmoud-Emad @AhmedHanafy725 @maayarosama @xmonader