Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ip validation #2987

Merged
merged 6 commits into from
Jun 20, 2024
Merged

Conversation

amiraabouhadid
Copy link
Contributor

Changes

checks if IP exists in all farms

Related Issues

#2726

Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, Amira! just small comment.

@MohamedElmdary
Copy link
Member

@amiraabouhadid for both methods toIpCheck ... ipcheck they will get value as parameter (should be current value) not sure if publicIp.value is synced with validation or not

amiraabouhadid and others added 4 commits June 19, 2024 17:00
Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>
Co-authored-by: Zainab Elgohary <40770501+zaelgohary@users.noreply.github.com>
@amiraabouhadid amiraabouhadid merged commit d8cf949 into development_2.6 Jun 20, 2024
4 checks passed
@amiraabouhadid amiraabouhadid deleted the development_2.6_add_ip_vald branch June 20, 2024 12:55
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants