Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent recursive component tree by displaying SSH keys alert #3026

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Prevent recursive component tree by displaying SSH keys alert #3026

merged 1 commit into from
Jun 25, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Jun 25, 2024 •
edited
Loading

Description

What happened? we normally use a view-layout component to wrap all of our views. When creating a new view, the expected structure is:

<view-layout>
  ...
</view-layout>

Recently, the component has been added to the SSHKeys view. and this isn't wrong, we import the SSHKeys component within the view-layout component when there are no SSH keys. This setup creates a recursive component tree, leading to a maximum call stack size exceeded error.

Changes

  • Removed the nested '' component from the 'SSHKeys' view.
  • Added an alert to inform users that SSH keys are required.
  • Included a link in the alert to direct users to the SSH keys page for easy access.

Related Issues

Screenshots

  • image

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
fix: prevent recursive component tree by displaying SSH keys alert:
ad991ce 
- Removed the nested '<view-layout>' component from the 'SSHKeys' view.
- Added an alert to inform users that SSH keys are required.
- Included a link in the alert to direct users to the SSH keys page for easy access.
@Mahmoud-Emad Mahmoud-Emad changed the title Prevent recursive component tree by displaying SSH keys alert: Prevent recursive component tree by displaying SSH keys alert Jun 25, 2024
0oM4R
0oM4R previously approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works fine

@0oM4R 0oM4R dismissed their stale review June 25, 2024 13:12

verifying the flow

@AhmedHanafy725 AhmedHanafy725 merged commit f0ac1e1 into development Jun 25, 2024
3 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_fix_sshkey_issue branch June 25, 2024 13:13
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samaradel samaradel samaradel approved these changes

@0oM4R 0oM4R 0oM4R left review comments

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Mahmoud-Emad @samaradel @0oM4R @xmonader @AhmedHanafy725