Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect and Resolve nodes' resources overlapping k8s/caprover #3040

Merged

Conversation

MohamedElmdary
Copy link
Member

Description

Detect and Resolve nodes' resources overlapping

Changes

  1. Add lock per deployment to avoid load more than one node at once (selecting nodes not series not parallel like before)
  2. Pass down other vms (aka. workers) down to each other
    For Example:
    Assume we have k8s cluster( 1 master, 2 workers [1, 2]) So,
    master <- take in - (worker 1, worker 2)
    worker 1 <- take in - (worker 2, master)
    worker 2 <- take in - (worker 1, master)
    and so on...
  3. Passing these info will allow to subtract resources from selected nodes (if any)
  4. if there is any node no longer valid for the required resources, will be omitted from the nodes list
    Note: Changing resources will reactively show/hide node in list
    For example:
    Let's assume we have a vm require 2 GB ram but the hidden node has 1.5 GB ram, so If we updated required resources to be less than or equal to 1.5 GB ram it will be added back the nodes list.
  5. Finally Update node on any vm (aka. worker) will trigger validation in other selected node if and only if it wasn't valid

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@MohamedElmdary MohamedElmdary self-assigned this Jun 26, 2024
@MohamedElmdary MohamedElmdary changed the title Detect and Resolve nodes' resources overlapping Detect and Resolve nodes' resources overlapping k8s/caprover Jun 26, 2024
@MohamedElmdary MohamedElmdary merged commit 6f39878 into development Jul 1, 2024
3 checks passed
@MohamedElmdary MohamedElmdary deleted the development_selected_nodes_resources_overlapping branch July 1, 2024 08:37
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants