Enhace unlock contracts dialog #3091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0oM4R
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
mohamedamer453 and
samaradel
as code owners
amiraabouhadid
approved these changes
Jul 7, 2024
|
please make sure that the action buttons are consistent with the rest of dialoges |
@samaradel please clarify what do you mean by make it consistent, this first screenshot have a disabled action button |
|
@0oM4R I mean, the space between the action btn and the dialog is different in the 2 dialogs I mentioned |
|
will include the enhancements in development pr |
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enhance style of unlock contracts dialog,
Changes
fix the header style of lock details
fix calculating the available balance
Related Issues
🐞 [Bug]: Unlocking grace period dialog enhancement #3082
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist