Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add billing docs #3141

Merged
merged 5 commits into from
Aug 14, 2024
Merged

Add billing docs #3141

merged 5 commits into from
Aug 14, 2024

Conversation

maayarosama
Copy link
Contributor

Description

Added billing docs to grid client

Related Issues

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@maayarosama maayarosama marked this pull request as ready for review July 31, 2024 05:10
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this document should be linked to the dedicated nodes when a user reserves a node. Additionally, it should be connected to the node contracts page and the calculation information for each solution.

@zaelgohary
Copy link
Contributor

Also, this should be in Playground docs not the Grid client.

packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While staking discounts are the same in all contracts, it's being repeated 3 times with dedicated nodes, node w public IP & with NU. Can we find a way to reduce the repetition?

@maayarosama
Copy link
Contributor Author

I think this document should be linked to the dedicated nodes when a user reserves a node. Additionally, it should be connected to the node contracts page and the calculation information for each solution.

Per discussion with @AhmedHanafy725 this's not needed, as users can easily check the prices using the calculator

packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
packages/grid_client/docs/billing.md Outdated Show resolved Hide resolved
@maayarosama maayarosama merged commit 3e4ac51 into development Aug 14, 2024
9 checks passed
@maayarosama maayarosama deleted the development_billing_docs branch August 14, 2024 12:24
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants