Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include setuptools installation in docs #3188

Merged
merged 6 commits into from
Aug 4, 2024
Merged

Include setuptools installation in docs #3188

merged 6 commits into from
Aug 4, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Jul 31, 2024 •
edited
Loading

Description

  • Add note for setuptools installation

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

AhmedHanafy725
AhmedHanafy725 reviewed Jul 31, 2024
View reviewed changes
Copy link
Contributor

@AhmedHanafy725 AhmedHanafy725 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add it too in the root readme?

AhmedHanafy725
AhmedHanafy725 reviewed Jul 31, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
packages/grid_client/README.md Outdated Show resolved Hide resolved
zaelgohary and others added 2 commits July 31, 2024 14:26
@zaelgohary @AhmedHanafy725
Update README.md
64c22f2 
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
@zaelgohary @AhmedHanafy725
Update packages/grid_client/README.md
4d21609 
Co-authored-by: AhmedHanafy725 <41957921+AhmedHanafy725@users.noreply.github.com>
@zaelgohary zaelgohary merged commit 905d3fe into development Aug 4, 2024
9 checks passed
@zaelgohary zaelgohary deleted the development_edit_grid_client_docs branch August 4, 2024 10:11
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maayarosama maayarosama maayarosama approved these changes

@amiraabouhadid amiraabouhadid amiraabouhadid approved these changes

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zaelgohary @AhmedHanafy725 @amiraabouhadid @maayarosama @xmonader