Edit vm & k8s deployment tables #3189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaelgohary
requested review from
AhmedHanafy725,
maayarosama,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
AhmedHanafy725
requested changes
Jul 31, 2024
samaradel
approved these changes
Jul 31, 2024
maayarosama
approved these changes
Aug 4, 2024
| return url.substring(url.lastIndexOf("/") + 1, url.lastIndexOf(".")); | ||
| } | ||
|
|
||
| return url.length > 40 ? url.substring(0, 40) + "..." : url; |
There was a problem hiding this comment.
we are showing the first part of the URL which is not useful and takes space from the table
There was a problem hiding this comment.
Should I remove the flist column?
There was a problem hiding this comment.
leave it. But crop the domain part and leave the flist name
AhmedHanafy725
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Related Issues
Checklist