Adding an NA icon in case of no flag image in Node details #3276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maayarosama
requested review from
AhmedHanafy725,
zaelgohary,
MohamedElmdary,
Mahmoud-Emad,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
0oM4R
reviewed
Aug 8, 2024
| @@ -40,6 +40,7 @@ | |||
|
|
|||
| <v-tooltip class="overflowText" v-if="item.hint && !item.icon" location="top" :text="item.hint"> | |||
| <template #activator="{ props }"> | |||
| <span class="flag-avatar" v-if="item.name === 'Flag' && !item.imgSrc">NA</span> | |||
There was a problem hiding this comment.
Would it be better if we added some padding top to the span?
There was a problem hiding this comment.
padding is added in flag-avatar class
0oM4R
reviewed
Aug 8, 2024
Comment on lines
38
to
39
| const x = getCountryFlagSrc(); | ||
| console.log("x ", x); |
There was a problem hiding this comment.
please remove the debug lines
0oM4R
approved these changes
Aug 14, 2024
| @@ -48,6 +48,9 @@ export default { | |||
| const getCountryFlagSrc = () => { | |||
| const conuntryCode = getCountryCode(props.node); | |||
|
|
|||
| if (conuntryCode.length > 2) { | |||
There was a problem hiding this comment.
It will be great if you fix this country typo
Mahmoud-Emad
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding an NA icon in case of no flag image in Node details
Related Issues
Documentation PR
For UI changes, Please provide the Documetation PR on info_grid
Checklist