Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubernetes_with_qsfs script #3288

Merged
merged 5 commits into from
Aug 22, 2024
Merged

Fix kubernetes_with_qsfs script #3288

merged 5 commits into from
Aug 22, 2024

Conversation

zaelgohary
Copy link
Contributor

@zaelgohary zaelgohary commented Aug 11, 2024 •
edited
Loading

Description

Issue happened because worker node was the same as the master's. Fixed by excluding the master node while filtering.

Changes

Add types, remove unnecessary code, ping node before deploying on it

Related Issues

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

amiraabouhadid
amiraabouhadid previously approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@amiraabouhadid amiraabouhadid left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passes
image
but shouldn't it be freeHRU >= disk_size * count?

@amiraabouhadid amiraabouhadid dismissed their stale review August 19, 2024 09:50

need to check something

@zaelgohary zaelgohary marked this pull request as draft August 20, 2024 14:02
@zaelgohary zaelgohary marked this pull request as ready for review August 22, 2024 15:01
@zaelgohary zaelgohary merged commit 93097ba into development Aug 22, 2024
9 checks passed
@zaelgohary zaelgohary deleted the development_fix_k8s_w_qsfs branch August 22, 2024 15:44
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zaelgohary @AhmedHanafy725 @amiraabouhadid @xmonader