Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update How to deploy a machine with mycelium network script #3310

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Update How to deploy a machine with mycelium network script #3310

merged 4 commits into from
Aug 22, 2024

Conversation

Mahmoud-Emad
Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad commented Aug 15, 2024 •
edited
Loading

Description

Updated the single_vm_mycelium script with some details about the MyCelium options

Changes

  • Documented the mycelium option
  • Documented the myceliumSeed option
  • Documented the seed option
  • Generate the seeds during the deployment instead of hard-codded them

Related Issues

Documentation PR

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

@Mahmoud-Emad
docs: Documented the mycelium options:
a50cc48 
- Documented the 'mycelium' option
- Documented the 'myceliumSeed' option
- Documented the 'seed' option
@Mahmoud-Emad Mahmoud-Emad marked this pull request as draft August 15, 2024 11:21
@Mahmoud-Emad
feat: Enhanced the 'single_vm_mycelium' script:
539acd2 
- Docuemented the 'network.myceliumSeeds.seed', 'machines.machine[any].mycelium', and 'machines.machine[any].myceliumSeed' options.
- Imported the missing types
@Mahmoud-Emad Mahmoud-Emad marked this pull request as ready for review August 15, 2024 13:10
zaelgohary
zaelgohary reviewed Aug 22, 2024
View reviewed changes
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I get this error whenever I try to run the script:

image

@Mahmoud-Emad
Copy link
Contributor Author

I get this error whenever I try to run the script:

image

fixed

@Mahmoud-Emad Mahmoud-Emad merged commit 57af865 into development Aug 22, 2024
9 checks passed
@Mahmoud-Emad Mahmoud-Emad deleted the development_mycelium branch August 22, 2024 15:32
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaelgohary zaelgohary zaelgohary approved these changes

@AhmedHanafy725 AhmedHanafy725 Awaiting requested review from AhmedHanafy725 AhmedHanafy725 is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

@0oM4R 0oM4R Awaiting requested review from 0oM4R 0oM4R is a code owner

@mohamedamer453 mohamedamer453 Awaiting requested review from mohamedamer453

@samaradel samaradel Awaiting requested review from samaradel samaradel is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.6.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Mahmoud-Emad @zaelgohary @amiraabouhadid @xmonader