Support managing domains in the K8S application #3312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Optimized the `ManageGatewy` component to work on both types of machines normal `VM` and `K8S` machine - Generate the name based on the master - takes the master networks as the domain supported networks - Change the dialog title to be dynamic - Working on refactoring the component
Mahmoud-Emad
requested review from
AhmedHanafy725,
zaelgohary,
maayarosama,
MohamedElmdary,
amiraabouhadid,
AlaaElattar,
0oM4R,
mohamedamer453 and
samaradel
as code owners
- Set the default port to 80 if props.vm - Set the default port to 443 if props.k8s
- Load the networks based on the selected node - Add the master/worker nodes on an array then display them all to let the user select from them.
MohamedElmdary
approved these changes
Aug 22, 2024
samaradel
approved these changes
Aug 26, 2024
amiraabouhadid
requested changes
Aug 27, 2024
amiraabouhadid
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The user might have some solutions on the cluster that require an ingress with a domain.
Changes
ManageGatewycomponent to work on both types of machines normalVMandK8SmachineRelated Issues
Screenshots/Video
Screencast.from.08-18-2024.03.10.58.PM.webm
Checklist