Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for all gateway interfaces #3319

Merged
merged 5 commits into from
Sep 2, 2024

Conversation

A-Harby
Copy link
Contributor

@A-Harby A-Harby commented Aug 19, 2024

Description

Add tests for gateway interfaces (Planetary, Mycelium, WireGuard, IPv4, and IPv6).

Changes

gateway.test.ts

Related Issues

#1284
#3148

Documentation PR

For UI changes, Please provide the Documetation PR on info_grid

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

Copy link
Contributor

@Mahmoud-Emad Mahmoud-Emad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ya 7arbii

@A-Harby A-Harby requested a review from Mahmoud-Emad August 21, 2024 15:02
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

solutionProviderId should be undefined. image

@A-Harby A-Harby requested a review from zaelgohary August 25, 2024 15:20
@A-Harby A-Harby requested a review from zaelgohary September 2, 2024 09:11
@A-Harby A-Harby requested a review from zaelgohary September 2, 2024 11:03
Copy link
Contributor

@zaelgohary zaelgohary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, ya Harby!

@A-Harby A-Harby merged commit 950107c into development Sep 2, 2024
9 checks passed
@A-Harby A-Harby deleted the development_jest_add_interfaces_gateway_tests branch September 2, 2024 11:38
@xmonader xmonader added this to the 2.6.0 milestone Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants