Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for client before calling clientoptions #3412

Merged
merged 2 commits into from
Sep 24, 2024
Merged

check for client before calling clientoptions #3412

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d333d30
check for client before calling clientoptions
amiraabouhadid Sep 17, 2024
8934688
group conditionals
amiraabouhadid Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions packages/playground/src/App.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,20 +336,19 @@ async function setTimeouts() {
}

const client = gridStore.client as GridClient;
const clientOptions = client.clientOptions;

const localStorageDeploymentTimeout = localStorage.getItem(LocalStorageSettingsKey.TIMEOUT_DEPLOYMENT_KEY);
const deploymentTimeoutMinutes = clientOptions.deploymentTimeoutMinutes;

if (client && clientOptions && deploymentTimeoutMinutes) {
if (!localStorageDeploymentTimeout) {
if (client && client.clientOptions) {
const deploymentTimeoutMinutes = client.clientOptions.deploymentTimeoutMinutes;
if (!localStorageDeploymentTimeout && deploymentTimeoutMinutes) {
localStorage.setItem(LocalStorageSettingsKey.TIMEOUT_DEPLOYMENT_KEY, `${+deploymentTimeoutMinutes * 60}`);
} else {
client.clientOptions.deploymentTimeoutMinutes = +localStorageDeploymentTimeout! / 60;
await client.connect();
}
}
}

// eslint-disable-next-line no-undef
const version = process.env.VERSION as any;

Expand Down
Loading