Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add release date for the applications #3493

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Add release date for the applications #3493

merged 3 commits into from
Oct 10, 2024

Conversation

samaradel
Copy link
Contributor

@samaradel samaradel commented Oct 2, 2024 •
edited
Loading

Description

  • Add release date for the applications for Gitea, Jenkins, Jitsi, Nostr, static website, Domains, and TFrobot.
  • Remove importing nextTick as it's not used anymore.

Changes

image

image

Related Issues

Tested Scenarios

  • The new label now is on Gitea, Jenkins, Jitsi, Nostr, static website, and TFrobot and will expire after 30 days.

Checklist

  • Tests included
  • Build pass
  • Documentation
  • Code format and docstrings
  • Screenshots/Video attached (needed for UI changes)

0oM4R
0oM4R requested changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jitsi is not added

@0oM4R
Copy link
Contributor

0oM4R commented Oct 2, 2024

also Domains solution should have the icon, please add it or open an issue for it

@0oM4R
Copy link
Contributor

0oM4R commented Oct 2, 2024

some solutions cards is not responsive, works fine on staging
image

@samaradel samaradel marked this pull request as draft October 2, 2024 12:56
@samaradel
Copy link
Contributor Author

also Domains solution should have the icon, please add it or open an issue for it

added

@samaradel
Copy link
Contributor Author

@0oM4R create an issue please for #3493 (comment) as it's not a part of this issue.

@samaradel samaradel marked this pull request as ready for review October 2, 2024 13:11
@samaradel samaradel requested a review from 0oM4R October 2, 2024 13:11
@0oM4R 0oM4R mentioned this pull request Oct 2, 2024
Closed
@0oM4R
Copy link
Contributor

0oM4R commented Oct 2, 2024

i commented with that on the original issue and reopened it

@0oM4R create an issue please for #3493 (comment) as it's not a part of this issue.

0oM4R
0oM4R approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@0oM4R 0oM4R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added and works fine on both themes

Screenshot from 2024-10-02 17-25-40
Screenshot from 2024-10-02 17-25-46

@samaradel samaradel marked this pull request as draft October 3, 2024 08:58
@samaradel samaradel marked this pull request as ready for review October 9, 2024 10:09
@AhmedHanafy725 AhmedHanafy725 merged commit 45dea6f into development Oct 10, 2024
10 checks passed
@AhmedHanafy725 AhmedHanafy725 deleted the development_update_apps branch October 10, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedHanafy725 AhmedHanafy725 AhmedHanafy725 approved these changes

@0oM4R 0oM4R 0oM4R approved these changes

@zaelgohary zaelgohary Awaiting requested review from zaelgohary zaelgohary is a code owner

@maayarosama maayarosama Awaiting requested review from maayarosama maayarosama is a code owner

@MohamedElmdary MohamedElmdary Awaiting requested review from MohamedElmdary MohamedElmdary is a code owner

@Mahmoud-Emad Mahmoud-Emad Awaiting requested review from Mahmoud-Emad Mahmoud-Emad is a code owner

@amiraabouhadid amiraabouhadid Awaiting requested review from amiraabouhadid amiraabouhadid is a code owner

@AlaaElattar AlaaElattar Awaiting requested review from AlaaElattar AlaaElattar is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samaradel @0oM4R @AhmedHanafy725